Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rasa server response timeout configurable #5358

Merged
merged 27 commits into from
Mar 17, 2020
Merged

Conversation

mmalhotra
Copy link
Contributor

@mmalhotra mmalhotra commented Mar 2, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨

@Ghostvv Ghostvv removed their request for review March 3, 2020 09:51
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨

Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmalhotra thanks a lot for your contribution 🎉

the code changes look great. can you please make sure all tests pass?

changelog/4756.improvement.rst Outdated Show resolved Hide resolved
@mmalhotra
Copy link
Contributor Author

@ricwo not sure why these checks are failing, I have fixed all the tests.

@mmalhotra mmalhotra requested a review from ricwo March 16, 2020 20:55
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests 🚀 I left a few more suggestions, but this is good to go afterwards

rasa/server.py Outdated Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
rasa/cli/arguments/run.py Outdated Show resolved Hide resolved
rasa/cli/arguments/run.py Outdated Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
rasa/server.py Show resolved Hide resolved
rasa/cli/arguments/run.py Outdated Show resolved Hide resolved
mmalhotra and others added 9 commits March 17, 2020 06:49
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
mmalhotra and others added 7 commits March 17, 2020 06:50
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
@ricwo ricwo merged commit 6b8090b into RasaHQ:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make Rasa Open Source response timeout configurable
3 participants