-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Rasa server response timeout configurable #5358
Conversation
Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨ |
Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmalhotra thanks a lot for your contribution 🎉
the code changes look great. can you please make sure all tests pass?
Co-Authored-By: ricwo <ric.wkr@gmail.com>
@ricwo not sure why these checks are failing, I have fixed all the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the tests 🚀 I left a few more suggestions, but this is good to go afterwards
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)