Duckling - handle intervals #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
reviewed
Nov 13, 2017
| "additional_info": match["value"], | ||
| "entity": match["dim"]} | ||
|
|
||
| try: |
There was a problem hiding this comment.
Lets do the following:
- put that code block before L104 and the entity object creation and store the extracted value in a tmp var
- lets move that whole common code block to a function to be used by both components
- I'd rather not do the try and except but rather decide where to get the value from using the
match["value"]["type"] == "interval"
There was a problem hiding this comment.
which file should I put the function in ideally?
tmbo
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):