Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add encoding #8286

Merged
merged 3 commits into from
Mar 24, 2021
Merged

add encoding #8286

merged 3 commits into from
Mar 24, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Mar 24, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge self-assigned this Mar 24, 2021
@wochinge wochinge mentioned this pull request Mar 24, 2021
Closed
@wochinge wochinge linked an issue Mar 24, 2021 that may be closed by this pull request
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 7835: character maps to <undefined> #8215
Closed
@wochinge wochinge requested a review from joejuzl March 24, 2021 11:07
@wochinge wochinge marked this pull request as ready for review March 24, 2021 11:07
@wochinge wochinge requested a review from a team March 24, 2021 11:07
joejuzl
joejuzl approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@joejuzl joejuzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might also be worth testing is_key_in_yaml directly too, just to be safe.

@wochinge wochinge enabled auto-merge March 24, 2021 16:58
@wochinge wochinge merged commit 35651b9 into 2.4.x Mar 24, 2021
@wochinge wochinge deleted the bugfix/is_key_in_yaml-encoding branch March 24, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejuzl joejuzl joejuzl approved these changes

Assignees

@wochinge wochinge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 7835: character maps to <undefined>
2 participants
@wochinge @joejuzl