Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Update examples #1510

Merged
merged 8 commits into from
Jan 3, 2019
Merged

Update examples #1510

merged 8 commits into from
Jan 3, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Dec 21, 2018 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • [ ] updated the documentation
  • updated the changelog

@wochinge wochinge force-pushed the update_examples branch 2 times, most recently from b6fa3fc to c42fa34 Compare January 2, 2019 13:46
MetcalfeTom
MetcalfeTom suggested changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@MetcalfeTom MetcalfeTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but concertbot is still kind of broken - its stories provide two different memoized responses to compare_reviews

And it still has no NLU, so add a note for our new users that they can speak in intents only

@wochinge
Copy link
Contributor Author

wochinge commented Jan 2, 2019

@MetcalfeTom ready for another review

@MetcalfeTom
Copy link
Contributor

MetcalfeTom commented Jan 3, 2019 •
edited
Loading

Could you just move the logger statements so that they are printed after training? Otherwise the message will be obscured by Keras epochs

Otherwise, great work!

@wochinge wochinge merged commit 1c7b28a into master Jan 3, 2019
@wochinge wochinge deleted the update_examples branch January 3, 2019 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MetcalfeTom MetcalfeTom MetcalfeTom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @MetcalfeTom