Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for bucklescript 8 #51

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Update for bucklescript 8 #51

merged 1 commit into from
Jul 1, 2020

Conversation

dfalling
Copy link
Contributor

@dfalling dfalling commented Jul 1, 2020

Updates for BuckleScript 8 changes.

/node_modules/reason-future/src/FutureJs.re 18:5-28:8

  16 │ let fromPromise = (promise, errorTransformer) =>
  17 │   Future.make(callback =>
  18 │     promise
  19 │     |> Js.Promise.then_(res =>
   . │ ...
  27 │          |> Js.Promise.resolve
  28 │        )
  29 │   );
  30 │

  This has type:
    Js.Promise.t(unit) (defined as Js.Promise.t(unit))
  But somewhere wanted:
    unit

bsrefmt made a few other minor changes too automatically. I can back those out if you'd like.

Comment on lines 5 to 6
external setTimeout: ([@bs.uncurry] (unit => unit), int) => timeoutId =
"setTimeout";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for the unsafe inferred external name warning.

@coveralls
Copy link

coveralls commented Jul 1, 2020

Pull Request Test Coverage Report for Build 89

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.947%

Totals Coverage Status
Change from base Build 87: 0.0%
Covered Lines: 161
Relevant Lines: 162

💛 - Coveralls

Comment on lines -49 to +50
);
)
->ignore;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main fix. Without this BuckleScript 8 now doesn't resolve the type as a unit.

@briangorman
Copy link
Collaborator

@dfalling Thanks for the PR, once the merge conflict is resolved I will merge.

@dfalling dfalling marked this pull request as draft July 1, 2020 13:33
@dfalling dfalling marked this pull request as ready for review July 1, 2020 13:37
@briangorman briangorman merged commit 661acca into RationalJS:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants