Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logging exceptions #1

Merged
merged 2 commits into from
Apr 7, 2015
Merged

Add support for logging exceptions #1

merged 2 commits into from
Apr 7, 2015

Conversation

chillitom
Copy link
Contributor

No description provided.

@Ravadre
Copy link
Owner

Ravadre commented Apr 7, 2015

Hello,

Including Exception fuctions is a good idea.

NLog does not discriminate any log levels and *Exception methods are defined for every log level. Maybe we could include Info/Debug/Trace as well to reflect this?

also removed calls to deprecated NLOG methods and used overloads instead
@chillitom chillitom changed the title Add support for WarnException, ErrorException and FatalException Add support for logging exceptions Apr 7, 2015
@Ravadre
Copy link
Owner

Ravadre commented Apr 7, 2015

Hi,

great, thanks. For some reason *Exception methods are not flagged deprecated, although I guess using newer overloads seem better idea.

Ravadre added a commit that referenced this pull request Apr 7, 2015
Add support for logging exceptions
@Ravadre Ravadre merged commit 1599561 into Ravadre:master Apr 7, 2015
@Ravadre
Copy link
Owner

Ravadre commented Apr 7, 2015

Updated NLog reference to 3.2.0 as it was missing in repo but it was already pushed to NuGet and published package version 3.2.0.1 which reference NLog 3.2.0 and your PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants