Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QT wallet speed issue caused by shadows on macOS #577

Closed
volbil opened this issue May 2, 2019 · 6 comments
Closed

QT wallet speed issue caused by shadows on macOS #577

volbil opened this issue May 2, 2019 · 6 comments
Assignees
Labels
gui QT issue

Comments

@volbil
Copy link
Contributor

volbil commented May 2, 2019

Describe the issue

QT shadows created by QGraphicsDropShadowEffect class is killing my MacBook, wallet slow and irresponsive. After I removed them (I removed getShadowEffect() which add them to GUI element) wallet start working like a charm. I haven't tried wallet on other systems, so it could be macOS specific issue.

Can you reliably reproduce the issue?

Yes, this issue is occured each time when I build QT wallet on my own.

If so, please list the steps to reproduce below:

  1. Autogen and configure Raven without any additional falgs on macOS.
  2. Build it.
  3. Run raven-qt wallet.

Expected behaviour

Wallet works without any issues.

Actual behaviour

Instead wallet work slow and barely respond to any interactions.

Machine specs:

  • OS: macOS Mojave 10.14.1
  • CPU: Intel Core i7 2,2 GHz
  • RAM: 16 GB 1600 MHz DDR3
  • Disk size: 256 GB
  • Disk Type (HD/SDD): SSD
@blondfrogs
Copy link
Contributor

@volbil Thanks for creating this, on the next release, I will remove the shadow effects of the wallet as performance is preferred over the look of the wallet.

@blondfrogs
Copy link
Contributor

@volbil Can you please test the build on my personal repo as see if my changes also fix this problems you were running into.
https://github.com/blondfrogs/Ravencoin/tree/test_issue_577

@volbil
Copy link
Contributor Author

volbil commented May 24, 2019

Hello @blondfrogs. Just tested your fix, works slightly better than before, but shadow on sidebar still present. It makes UI bit irresponsive. After I commenting out this code qt wallet start working much faster. Here is final result without sidebar shadow:
Wallet without shadows

@blondfrogs
Copy link
Contributor

oops forgot about the side bar, that one is declared in a different area. Will update

@volbil
Copy link
Contributor Author

volbil commented May 25, 2019

Thanks @blondfrogs !

@HyperPeek
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui QT issue
Projects
None yet
Development

No branches or pull requests

4 participants