Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring on M1 mac fails (macOS 14) #281

Open
gerd-moellmann opened this issue Feb 29, 2024 · 4 comments · May be fixed by #283
Open

Configuring on M1 mac fails (macOS 14) #281

gerd-moellmann opened this issue Feb 29, 2024 · 4 comments · May be fixed by #283
Assignees
Labels
needs analaysis The issue needs analysis before it can be resolved.

Comments

@gerd-moellmann
Copy link

Configuring mps (./configure ...) on an M1 mac with macOS 14.3.1 fails for me. Making the change below and regenerating configure with autoconf lets me build, and all tests succeeded.

modified   configure.ac
@@ -91,6 +91,17 @@ case $host/$CLANG in
       TEST_TARGET=test-xcode-build
       PFMCFLAGS="$CFLAGS_LL"
     ;;
+  arm-apple-darwin*/*)
+      AC_MSG_RESULT([Mac OS X ARM64])
+      MPS_OS_NAME=xc
+      MPS_ARCH_NAME=a6
+      MPS_BUILD_NAME=ll
+      BUILD_TARGET=build-via-xcode
+      CLEAN_TARGET=clean-xcode-build
+      INSTALL_TARGET=install-xcode-build
+      TEST_TARGET=test-xcode-build
+      PFMCFLAGS="$CFLAGS_LL"
+    ;;
   i*86-*-darwin*/*)
       AC_MSG_RESULT([Mac OS X x86])
       MPS_OS_NAME=xc

@waywardmonkeys
Copy link
Contributor

It is odd, but I get arm there as well. (Not arm64, not aarch64.)

Support for this platform was previously added in e5066a7 ... so I'm curious if this changed since then or what.

@thejayps thejayps added the needs analaysis The issue needs analysis before it can be resolved. label Feb 29, 2024
@thejayps thejayps self-assigned this Feb 29, 2024
@waywardmonkeys
Copy link
Contributor

I've done some analysis and will submit a PR momentarily for what I found.

waywardmonkeys added a commit to waywardmonkeys/mps that referenced this issue Feb 29, 2024
Fixes Ravenbrook#281. Identification of newer systems such as macOS on Apple
Silicon was not working correctly with the old version of this
file.
@waywardmonkeys
Copy link
Contributor

See PR #283.

@gerd-moellmann
Copy link
Author

gerd-moellmann commented Mar 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs analaysis The issue needs analysis before it can be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants