Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M_PI does not exist for MSVC #207

Closed
trevordblack opened this issue Sep 28, 2019 · 5 comments
Closed

M_PI does not exist for MSVC #207

trevordblack opened this issue Sep 28, 2019 · 5 comments
Assignees
@ronaldfw
Labels
area: code
Milestone
v3

Comments

@trevordblack
Copy link
Collaborator

MSVC throws errors looking for M_PI
@trevordblack
Copy link
Collaborator Author

https://stackoverflow.com/questions/6563810/m-pi-works-with-math-h-but-not-with-cmath-in-visual-studio

@hollasch
Copy link
Collaborator

My vote is to keep it simple. In our constants file (which I think Ronald is working on), we should just use

const <floatType> pi = 3.1415926535897932385;

@ronaldfw
Copy link
Contributor

Fixed on the future branch.

@hollasch hollasch added this to the v3 milestone Oct 8, 2019
@hollasch
Copy link
Collaborator

hollasch commented Oct 8, 2019

This should go in to v3 (the development branch).

@hollasch
Copy link
Collaborator

Done and now in the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronaldfw ronaldfw

Labels
area: code
Projects
None yet
Milestone
v3
Development

No branches or pull requests
3 participants
@hollasch @trevordblack @ronaldfw