Fix section describing total internal reflection #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a sphere of index of refraction greater than the surrounding medium, there is no incoming ray that can be chosen to show total internal reflection. An incoming ray will be bent to a smaller angle relative to the surface normal, and then bent back to the original angle on exit. To illustrate total reflection, this change renders a bubble of air inside water. Glancing rays are then reflected off the surface instead of refracted. In the service of this change, I've also moved the center sphere back a bit from the left and right spheres so you can see the affected side more clearly. This will invalidate all of the other three-sphere images, which will be fixed up in #1358 (Alpha.2 milestone verify Book 1 progression). Resolves #900
armansito
approved these changes
Mar 19, 2024
rupsis
added a commit
that referenced
this pull request
Mar 27, 2024
rupsis
added a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a sphere of index of refraction greater than the surrounding medium, there is no incoming ray that can be chosen to show total internal reflection. An incoming ray will be bent to a smaller angle relative to the surface normal, and then bent back to the original angle on exit.
To illustrate total reflection, this change renders a bubble of air inside water. Glancing rays are then reflected off the surface instead of refracted.
In the service of this change, I've also moved the center sphere back a bit from the left and right spheres so you can see the affected side more clearly. This will invalidate all of the other three-sphere images, which will be fixed up in #1358 (Alpha.2 milestone verify Book 1 progression).
Resolves #900