This repository has been archived by the owner on Aug 10, 2020. It is now read-only.
Deepify #6
Closed
Deepify #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage.json and Makefile
- simply sets the value to the array.. for now
|
The deep algorithm is far too naive. I actually think deep copying is out of scope for this module. There are other ways modules that do deep copies. |
|
Naive or not, it wasn't meant to be overly complex. Seems to work pretty well based on tests. If it's out of scope, then no worries.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it would be cool if xtend allowed for deep extensions. I also updated the readme with the new example and added test using mocha and chai. Hope you like it, please let me know if you see any issues.
-Steve