Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Template's home page html has bad url when using a custom PathBase #185

Closed
apexdodge opened this issue Mar 30, 2024 · 0 comments
Closed

Default Template's home page html has bad url when using a custom PathBase #185

apexdodge opened this issue Mar 30, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
v1.2.0

Comments

@apexdodge
Copy link
Contributor

If you enable a custom pathbase, the screenshot that pulls from the default assets does not appear because the url is a bit mangled.

See line of code here:

raytha/src/Raytha.Domain/Entities/DefaultTemplates/raytha_html_home.liquid

Line 15 in 407bedf

<img src="{{ PathBase}}raytha_default_2024/assets/images/raythadotcom_screenshot.webp" class="img-fluid border rounded-3 shadow-lg mb-4" alt="Example image" width="700" height="500" loading="lazy">

It should be:

{{ PathBase }}/raytha_default_2024/assets/images/raythadotcom_screenshot.webp

(missing / before raytha_default_2024)
@apexdodge apexdodge added the bug Something isn't working label Mar 30, 2024
@apexdodge apexdodge added this to the v1.2.0 milestone Mar 30, 2024
apexdodge added a commit that referenced this issue Mar 31, 2024
@apexdodge
Fixes bad link for default home page #185
150ae75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@apexdodge