Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update one test for increased qnorm precision in R 4.3.0 #1251

Closed
eddelbuettel opened this issue Feb 7, 2023 · 0 comments
Closed

Update one test for increased qnorm precision in R 4.3.0 #1251

eddelbuettel opened this issue Feb 7, 2023 · 0 comments

Comments

@eddelbuettel
Copy link
Member

Reading the r-devel changes RSS feed has its benefits as I noticed the other day (Feb 4 to precise) that

CHANGES IN R-devel NEW FEATURES
‘qnorm(, log.p=TRUE)’ is now fully accurate (instead of to “only” minimally five digits).

And indeed, we now get

  ----- FAILED[data]: test_stats.R<246--246>
   call| expect_equal(runit_qnorm_log(-1e+05)$lower, -447.1974945)
   diff| Expected '-447.1974945', got '-447.197893678525'
  Error: 1 out of 1590 tests failed

Fix is easy and I'll push it once the CITATION issue in #1250 is dealt with.
@eddelbuettel eddelbuettel mentioned this issue Feb 7, 2023
Merged
4 tasks
eddelbuettel added a commit that referenced this issue Feb 7, 2023
@eddelbuettel
Merge pull request #1252 from RcppCore/bugfix/qnorm_test
7fc0a8f 
Use more accurate qnorm value from R 4.3.0 (Closes #1251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddelbuettel