Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more accurate qnorm value from R 4.3.0 (Closes #1251) #1252

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

eddelbuettel
Copy link
Member

R-devel, per the Feb 4 NEWS post, now have a more accurate qnorm. We need to reflect that in a test.

There may a 'timing' issue with the docker container used for r-devel, but if this fails now I will update the container. The new tests passes locally.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Alternatively, we could set e.g. a tolerance=0.0005 and call it a day. But this is fine too.

@eddelbuettel eddelbuettel merged commit 7fc0a8f into master Feb 7, 2023
@eddelbuettel eddelbuettel deleted the bugfix/qnorm_test branch February 7, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants