New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert uses of inline::cxxfunction to attributes. #56
Comments
Listing of grep -rnw '.' -e "cxxfunction"
|
Yes, sadly (empirically speaking) this is apparently not really all that relevant it would appear as nobody stepped forward to rewrite all of these in the meantime. To take but one example: Not sure how to get from here to there. |
Does this mean you would be open to an "Rcpp Examples" vignette? Where each package highlights its own implementation of By the way, I also wrote a short snippet on the calculation procedure of
|
Plan:
Thoughts? Also inline usage within |
Commenting backwards:
|
Okay, so to fulfill this:
Is this okay @eddelbuettel ? |
I would prefer to do things one at a time. Let's looks at converting a vignette at a time. Also let's not change all examples all at once, but maybe by directory. We could also consider just removing them, or completely rewrite them, or move them to RcppExamples. Needs some thought and discussion first, I think. |
I meant to say, 1 PR per bullet tied to this issue. Clear on individual PRs for vignette changes. I remember a long time ago on a different issue there were potential issues with moving examples out of a package due to pre-existing links. (I know this is shooting the revamp of the examples in the foot... But...) As this is directly associated with examples, I vote to have the discussion around either moving the examples / completely rewriting them here. I'm only in favor of a rewrite to modernize the examples. I think moving them into RcppExamples is too much. |
All those points sound good to me. I have done similar stuff eg here for an RcppGSL example. This one has four example --- because things got better incrementally. So we could keep what is there (preserving links, a plus), keep the old example (being honest) but promote a better newer one. |
This issue is stale (365 days without activity) and will be closed in 31 days unless new activity is seen. Please feel free to re-open it is still a concern, possibly with additional data. |
There are lots of examples still using
cxxfunction
.We need to replace this by uses of
sourceCpp
orcppFunction
.The text was updated successfully, but these errors were encountered: