Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing Rcpp-extends & external pointer macros (closes #416) #592

Merged
merged 2 commits into from
Nov 23, 2016
Merged

Modernizing Rcpp-extends & external pointer macros (closes #416) #592

merged 2 commits into from
Nov 23, 2016

Conversation

coatless
Copy link
Contributor

@coatless coatless commented Nov 19, 2016

Preview of changed Rcpp-extending.pdf

@eddelbuettel
Copy link
Member

Let me take another look tomorrow ...

@eddelbuettel
Copy link
Member

I like it. That was missing, and this fills a void.

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good too.

@@ -3,6 +3,13 @@
\newcommand{\ghpr}{\href{https://github.com/RcppCore/Rcpp/pull/#1}{##1}}
\newcommand{\ghit}{\href{https://github.com/RcppCore/Rcpp/issues/#1}{##1}}

\section{Changes in Rcpp version 0.12.8 (2017-01-xx)}{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, forgot to bump version info here..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. With the multiple PRs out it may require some manual tweaking anyway.

@eddelbuettel eddelbuettel merged commit 8bc8790 into RcppCore:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants