Modernizing Rcpp-extends & external pointer macros (closes #416) #592

Merged
merged 2 commits into from Nov 23, 2016

Projects

None yet

2 participants

@coatless
Contributor
coatless commented Nov 19, 2016 edited
  • Switch away from using inline in favor of Rcpp attributes (#56).
  • Fixed a few typos (duplicate includes and “non intrusive” vs. “non-intrusive”)
  • Added three paragraphs about exposing pointers proposed in #416 by @MathurinD.

Preview of changed Rcpp-extending.pdf

@eddelbuettel
Member

Let me take another look tomorrow ...

@eddelbuettel
Member

I like it. That was missing, and this fills a void.

@eddelbuettel

Looks good too.

@@ -3,6 +3,13 @@
\newcommand{\ghpr}{\href{https://github.com/RcppCore/Rcpp/pull/#1}{##1}}
\newcommand{\ghit}{\href{https://github.com/RcppCore/Rcpp/issues/#1}{##1}}
+\section{Changes in Rcpp version 0.12.8 (2017-01-xx)}{
@coatless
coatless Nov 22, 2016 Contributor

Eh, forgot to bump version info here..

@eddelbuettel
eddelbuettel Nov 23, 2016 Member

No worries. With the multiple PRs out it may require some manual tweaking anyway.

@eddelbuettel eddelbuettel merged commit 8bc8790 into RcppCore:master Nov 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment