Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible (minimal ?) need for two compileAttributes() runs #934

Closed
eddelbuettel opened this Issue Jan 31, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@eddelbuettel
Copy link
Member

eddelbuettel commented Jan 31, 2019

This comes courtesy of a colleague. If one does

  1. Create 'New package with Rcpp' followed by Build->Install+Restart -- OK
  2. Add new C++ file using the examples, saved in src/ as .e.g. `src/doubleMe.src, Install+Restart -- OK
  3. Now delete the initial src/rcpp_hello_world.cpp, Install+Restart --> Link error

Two runs of compileAttributes() fix it, but the IDE does not suggest it. Can we think of a heuristic to figure out when to run it twice?

@coatless

This comment has been minimized.

Copy link
Contributor

coatless commented Jan 31, 2019

@kevinushey already produced a reprex c.f. #733 (comment)

@eddelbuettel

This comment has been minimized.

Copy link
Member Author

eddelbuettel commented Jan 31, 2019

Thanks for that -- I once knew that too.

@coatless

This comment has been minimized.

Copy link
Contributor

coatless commented Jan 31, 2019

tl;dr of the story: the bug effects ~1% < of the developer base and is quickly solved by re-running hence there never was a push to fix it.

@eddelbuettel

This comment has been minimized.

Copy link
Member Author

eddelbuettel commented Jan 31, 2019

It does frustrate users.

So I am wondering if we should just run the (still very fast) compileAttributes() twice.

rstub pushed a commit to rstub/Rcpp that referenced this issue Feb 9, 2019

@eddelbuettel

This comment has been minimized.

Copy link
Member Author

eddelbuettel commented Feb 26, 2019

Closed via #939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.