fix issue with 'stale' symbols being registered #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #733, #934.
The underlying issue here IIUC is that the machinery that attempts to discover used symbols was also crawling the various RcppExports files, and since those were 'stale' at the time when
compileAttributes()is run, they would incorrectly contribute 'old' symbols which would then remain incorrectly registered.The fix here removes the R-level
RcppExports.Rfile (since we want to ensure thattools::package_native_routine_registration_skeleton()doesn't touch it), and also removesRcppExports.cppfrom the set of files we crawl for exportable functions.