Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with 'stale' symbols being registered #939

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@kevinushey
Copy link
Contributor

kevinushey commented Feb 12, 2019

Closes #733, #934.

The underlying issue here IIUC is that the machinery that attempts to discover used symbols was also crawling the various RcppExports files, and since those were 'stale' at the time when compileAttributes() is run, they would incorrectly contribute 'old' symbols which would then remain incorrectly registered.

The fix here removes the R-level RcppExports.R file (since we want to ensure that tools::package_native_routine_registration_skeleton() doesn't touch it), and also removes RcppExports.cpp from the set of files we crawl for exportable functions.

@jjallaire jjallaire requested review from jjallaire and removed request for jjallaire Feb 12, 2019

@jjallaire

This comment has been minimized.

Copy link
Member

jjallaire commented Feb 12, 2019

LGTM

@eddelbuettel eddelbuettel merged commit f0bae39 into master Feb 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the bugfix/compile-attibutes-stale-symbols branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.