support include files for package names with dot (closes #1129) #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 64 64
Lines 2735 2739 +4
=======================================
+ Hits 2667 2671 +4
Misses 68 68
|
eddelbuettel
added a commit
to Enchufa2/Rcpp
that referenced
this pull request
Jan 17, 2021
eddelbuettel
added a commit
to Enchufa2/Rcpp
that referenced
this pull request
Jan 17, 2021
5 tasks
|
Given the comment here I will go ahead and merge this now. |
eddelbuettel
added a commit
to Enchufa2/Rcpp
that referenced
this pull request
Jan 18, 2021
eddelbuettel
added a commit
that referenced
this pull request
Jan 19, 2021
eddelbuettel
added a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
R CMD checkstill passes all testsThis addresses the issue in #1129 which itself bring back up #500 and related SO question. The fix is actually pretty simple, was made (and even tested) a few weeks ago.