Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot in package names bites Rcpp Atttributes #500

Closed
eddelbuettel opened this issue Jul 2, 2016 · 0 comments

Comments

@eddelbuettel
Copy link
Member

commented Jul 2, 2016

As reported by @deepayan (in reference to Modules but breaks in even simpler cases).

Example:

edd@don:/tmp$ R -e 'Rcpp::Rcpp.package.skeleton("with.dot")'
edd@don:/tmp$ R CMD build with.dot 
edd@don:/tmp$ R CMD check with.dot_1.0.tar.gz 

which ends in

edd@don:/tmp$ cat /tmp/with.dot.Rcheck/00install.out
* installing *source* package ‘with.dot’ ...
** libs
ccache g++ -I/usr/share/R/include -DNDEBUG   -I"/usr/local/lib/R/site-library/Rcpp/include"   -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -O3 -Wall -pipe -Wno-unused -pedantic -c RcppExports.cpp -o RcppExports.o
RcppExports.cpp:10:21: error: expected initializer before ‘.’ token
 RcppExport SEXP with.dot_rcpp_hello_world() {
                     ^
/usr/lib/R/etc/Makeconf:141: recipe for target 'RcppExports.o' failed
make: *** [RcppExports.o] Error 1
ERROR: compilation failed for package ‘with.dot’
* removing ‘/tmp/with.dot.Rcheck/with.dot’

#403 is similar but just for function names. We need a similar s/\./_/ here.

thirdwing pushed a commit to thirdwing/Rcpp that referenced this issue Jul 2, 2016
thirdwing pushed a commit to thirdwing/Rcpp that referenced this issue Jul 3, 2016
thirdwing pushed a commit to thirdwing/Rcpp that referenced this issue Jul 3, 2016
eddelbuettel added a commit that referenced this issue Jul 3, 2016
replace '.' in package name (close #500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.