Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for containerbuilds #1181

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Add action for containerbuilds #1181

merged 3 commits into from
Oct 2, 2021

Conversation

eddelbuettel
Copy link
Member

This PR adds a simple-enough workflow to create containers used for CI as well two convenience add-ons.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that, if you wish, it could be further simplified by stacking together the build&push steps for run and plus in the same job, just one after the other:

    - name: Build and push
      uses: docker/build-push-action@v2
      with:
        push: true
        context: docker/run
        tags: rcpp/run

    - name: Build and push
      uses: docker/build-push-action@v2
      with:
        push: true
        context: docker/plus
        tags: rcpp/plus

@eddelbuettel
Copy link
Member Author

Fair point. I will consider that for another revision.

@eddelbuettel eddelbuettel merged commit 743bef2 into master Oct 2, 2021
@eddelbuettel eddelbuettel deleted the feature/docker branch October 2, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants