Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support C++20 and C++23 (in r-devel) #1228

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Support C++20 and C++23 (in r-devel) #1228

merged 5 commits into from
Sep 20, 2022

Conversation

eddelbuettel
Copy link
Member

r-devel now support C++23 as a compilation standard (if and when the compiler does) so we added a plugin. We also added one for C++20 which we had apparently skipped.

Tested both under r-devel (svn r82883) and worked.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

R/Attributes.R Outdated Show resolved Hide resolved
R/Attributes.R Outdated Show resolved Hide resolved
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just note that there's already a cpp2a plugin

Rcpp/R/Attributes.R

Lines 572 to 574 in bb7cebb

.plugins[["cpp2a"]] <- function() {
list(env = list(PKG_CXXFLAGS ="-std=c++2a"))
}
so we could add the cpp2b too for completeness.

@eddelbuettel
Copy link
Member Author

Yup -- added '2b' for symmetry as well. Helps cover more compilers -- thanks for patiently arguing for that.

@eddelbuettel eddelbuettel merged commit 8a44ae1 into master Sep 20, 2022
@eddelbuettel eddelbuettel deleted the feature/c++23 branch September 20, 2022 18:53
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants