-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support C++20 and C++23 (in r-devel) #1228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just note that there's already a cpp2a plugin
Lines 572 to 574 in bb7cebb
.plugins[["cpp2a"]] <- function() { | |
list(env = list(PKG_CXXFLAGS ="-std=c++2a")) | |
} |
Yup -- added '2b' for symmetry as well. Helps cover more compilers -- thanks for patiently arguing for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belated LGTM!
r-devel now support C++23 as a compilation standard (if and when the compiler does) so we added a plugin. We also added one for C++20 which we had apparently skipped.
Tested both under r-devel (svn r82883) and worked.
Checklist
R CMD check
still passes all tests