Quoting only non-standard paths on linux

[llaniewski]

This closes #1242

Checklist

• Code compiles correctly
• R CMD check still passes all tests
• Prefereably, new tests were added which fail without the change
• Document the changes by file in ChangeLog

[eddelbuettel]

Thanks for adding changelog and news, and flipping from = to <-. I would probably still reorder the logic in function to (untested)

Rcpp.quoteNonStandard <- function(path, quoteAll = .Platform$OS.type!="unix") {
    ## Check if path has only characters that do not need quoting
    sel <- grepl("^[[:alnum:]/._~+@%-]*$", path)
    ## If no quoting needed return unchanged else quote input
    if (sel) path else shQuote(path)
}

Simpler?

[llaniewski]

I simplified the function for single path input, and removed the option, as it was not used. Hope this looks good now.

[eddelbuettel]

👍 -- looks great! I'll wait a bit in case Kevin or Inaki find something objectionable but will otherwise merge and roll up a first 1.0.10.1 with this.

[Enchufa2]

For the regexp, I suggest following some well-established reference. For example, this is what pkgconfig escapes in paths:

if ((s[0] < '+') ||
    (s[0] > '9' && s[0] < '@') ||
    (s[0] > 'Z' && s[0] < '^') ||
    (s[0] == '`') ||
    (s[0] > 'z')) {
	r[c] = '\\';
	c++;
}

So the inverse would be allowed characters.

[eddelbuettel]

Good idea in theory. In practice ... maybe I am lacking coffee (only one cup in) but what exactly are you proposing? A per-character loop? A re-written regexp? Can you sketch something I actually think the regexp is reasonably careful as is.

[Enchufa2]

A re-written regexp. Following the ASCII table and the reference above, it seems after all that the only difference would be ^ instead of %. But I don't see why % would require quotation. :-\ I suppose it's good enough as it is. Don't mind me. Sorry for the noise.

[eddelbuettel]

Extra eyes on the ball are a good thing. Thanks for checking!