Silence two tests #1245
Merged
Silence two tests #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guilty! That test is not doing what I expected... I can fix it instead of silencing it. May I? |
|
Yes, just use the branch (and update/alter what I did as needed). I poked around with |
|
Now it's me who requests your review, but GitHub doesn't allow me to add you, I suppose because you started this PR. :) |
eddelbuettel
commented
Jan 29, 2023
eddelbuettel
commented
Jan 29, 2023
|
|
||
| * inst/tinytest/test_xptr.R: Condition one test writing to stdout | ||
| on test verbosity environment variable being set | ||
| * inst/tinytest/test_xptr.R: Fix a couple of tests writing to stdout |
There was a problem hiding this comment.
'A couple' ? 'A pair' 😜
There was a problem hiding this comment.
They're married by their purpose. :)
eddelbuettel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trivial PR makes one test (that otherwise barks on
stdout) conditional on the env var making some tests quiet. As we usesystem()the stdout capture of tinytest does not work for us.Checklist
R CMD checkstill passes all tests