Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace '.' in package name (close #500) #501

Merged
merged 1 commit into from Jul 3, 2016

Conversation

@thirdwing
Copy link
Member

commented Jul 2, 2016

@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Jul 2, 2016

You rock. @jjallaire talked about this, but still at DSC so no work done. Patch looks fine.

@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Jul 2, 2016

I built Rcpp based on that branch, but the same process as above (i.e. in /tmp/ create a package with a dot in its name and runR CMD build ...followed byR CMD check ...`) did not work. :-/

Did it work for you? Was I doing something wrong?

@thirdwing

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2016

* using log directory ‘/private/tmp/with.dot.Rcheck’
* using R version 3.2.2 (2015-08-14)
* using platform: x86_64-apple-darwin13.4.0 (64-bit)
* using session charset: UTF-8
* checking for file ‘with.dot/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘with.dot’ version ‘1.0’
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘with.dot’ can be installed ... WARNING
Found the following significant warnings:
  /Library/Frameworks/R.framework/Versions/3.2/Resources/library/Rcpp/include/Rcpp/algorithm.h:48:62: warning: 'long long' is a C++11 extension [-Wc++11-long-long]
  /Library/Frameworks/R.framework/Versions/3.2/Resources/library/Rcpp/include/Rcpp/algorithm.h:77:80: warning: 'long long' is a C++11 extension [-Wc++11-long-long]
  /Library/Frameworks/R.framework/Versions/3.2/Resources/library/Rcpp/include/Rcpp/algorithm.h:89:43: warning: 'long long' is a C++11 extension [-Wc++11-long-long]
  /Library/Frameworks/R.framework/Versions/3.2/Resources/library/Rcpp/include/Rcpp/algorithm.h:100:61: warning: 'long long' is a C++11 extension [-Wc++11-long-long]
  /Library/Frameworks/R.framework/Versions/3.2/Resources/library/Rcpp/include/Rcpp/algorithm.h:117:43: warning: 'long long' is a C++11 extension [-Wc++11-long-long]
  /Library/Frameworks/R.framework/Versions/3.2/Resources/library/Rcpp/include/Rcpp/algorithm.h:128:61: warning: 'long long' is a C++11 extension [-Wc++11-long-long]
See ‘/private/tmp/with.dot.Rcheck/00install.out’ for details.
* checking installed package size ... OK
* checking package directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... WARNING
Foreign function call to a different package:
  .Call("with_dot_rcpp_hello_world", ..., PACKAGE = "with_dot")
Undeclared package in foreign function calls:
   ‘with_dot’
See chapter ‘System and foreign language interfaces’ in the ‘Writing R
Extensions’ manual.
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking compiled code ... OK
* checking examples ... OK
* checking PDF version of manual ... OK
* DONE
Status: 2 WARNINGs
@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Jul 2, 2016

Weird. I will retrace my steps.

@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Jul 2, 2016

I think I was in the wrong branch.

@dcdillon

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

The long long warnings are puzzling as all references to long long seem to be wrapped in ifdefs appropriately

@kevinushey

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

I don't think we can rename the package name unconditionally like that (re: the warnings you pointed out). We only want to munge the package name when constructing the C++ function name (and, presumedly, make sure the same change happens for the function name used in the R function wrapper)

@thirdwing

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2016

@kevinushey You are right. I will update this soon.

@thirdwing thirdwing force-pushed the thirdwing:master branch from b7b0b9c to 96167a2 Jul 3, 2016
@thirdwing

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2016

* using log directory ‘/tmp/with.dot.Rcheck’
* using R version 3.2.2 (2015-08-14)
* using platform: x86_64-pc-linux-gnu (64-bit)
* using session charset: UTF-8
* checking for file ‘with.dot/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘with.dot’ version ‘1.0’
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘with.dot’ can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking compiled code ... OK
* checking examples ... OK
* checking PDF version of manual ... OK
* DONE
Status: OK
@thirdwing thirdwing force-pushed the thirdwing:master branch from 96167a2 to ddd9ebd Jul 3, 2016
@thirdwing thirdwing force-pushed the thirdwing:master branch from ddd9ebd to 83fefe3 Jul 3, 2016
@kevinushey

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2016

Very nice!

@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Jul 3, 2016

I will get to it tomorrow (while traveling home). I accidentally operated from an Rcpp repo branch even though I had not merged it. A clear -1 on git skillz for me ...

@eddelbuettel eddelbuettel merged commit 7ea2f04 into RcppCore:master Jul 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Jul 3, 2016

Nice work, @thirdwing. Now merged.

eddelbuettel added a commit that referenced this pull request Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.