Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing Rcpp namespace in export interface generation #779

Merged
merged 1 commit into from
Dec 1, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2017-11-30 James J Balamuta <balamut2@illinois.edu>

* src/attributes.cpp: Fixed missing Rcpp namespace in export interface
generation

2017-11-25 Dirk Eddelbuettel <edd@debian.org>

* DESCRIPTION (Version, Date): Roll minor version
Expand Down
6 changes: 6 additions & 0 deletions inst/NEWS.Rd
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@
\itemize{
\item Calls from exception handling to `Rf_warning()` now correctly set an
initial format string (Dirk in \ghpr{777} fixing \ghit{776}).
}
\item Changes in Rcpp Attributes:
\itemize{
\item Addressed a missing Rcpp namespace prefix when generating a C++
interface (James Balamuta in \ghpr{779}).
}
\item Changes in Rcpp Documentation:
\itemize{
\item The Rcpp FAQ now shows \code{Rcpp::Rcpp.plugin.maker()}m not the
Expand Down
2 changes: 1 addition & 1 deletion src/attributes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2192,7 +2192,7 @@ namespace attributes {
<< std::endl;
ostr() << " if (rcpp_result_gen.inherits(\"try-error\"))"
<< std::endl
<< " throw Rcpp::exception(as<std::string>("
<< " throw Rcpp::exception(Rcpp::as<std::string>("
<< "rcpp_result_gen).c_str());"
<< std::endl;
if (!function.type().isVoid()) {
Expand Down