-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion & unit tests for dgT, dtT & dsTMatrix #136
Conversation
Wait, there seem to some of the same commits in both pull requests. That's generally not a great idea. |
Maybe I should first close this PR. |
I now merged #135. If we're careful we could probably open this and merge it too. We can either open, and merge (maybe simplest) or cherry pick the last two commits. In general, let's try to only work on one open PR at a time. I'm sorry I took four days on the last one but review is useful. |
There is however a conflict now so that would have to be resolved first. |
Might I suggest for this PR that @eddelbuettel uses a merge squash? In essence, the working history of the branch is condensed into one commit that is added into the master. This keeps all of the changes of the PR together without adding the duplicate history from the previous PR back into the master. Merge and squash via:
|
Yes. I already used a merge squash on the last one. Trivial from GitHub's GUI. |
Missed that. Awesome! |
No worries, and thanks for the CLI reminder. Noted, and copied to local README. |
Tests find on my end in a branch, so in it goes. Hurray :) |
In order to solve #17 and #114.