Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.data.table() no longer writes 'x' to .GlobalEnv #2830

Merged
merged 1 commit into from
May 3, 2018
Merged

Conversation

mattdowle
Copy link
Member

Closes #2828

@mattdowle mattdowle added this to the 1.11.2 milestone May 3, 2018
@codecov-io
Copy link

codecov-io commented May 3, 2018

Codecov Report

Merging #2830 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
- Coverage   93.45%   93.45%   -0.01%     
==========================================
  Files          61       61              
  Lines       12369    12367       -2     
==========================================
- Hits        11560    11558       -2     
  Misses        809      809
Impacted Files Coverage Δ
R/test.data.table.R 100% <100%> (ø) ⬆️
src/fsort.c 73.61% <0%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93660f8...8b8f008. Read the comment docs.

@mattdowle mattdowle merged commit c5c32e1 into master May 3, 2018
@mattdowle mattdowle deleted the noglobal branch May 3, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants