#53: improve join queue + added commands to set messages #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new commands to set the join and leave message of a queue
/admin setjoinmessage message queue
/admin setleavemessage message queue
added closing_time and acitve_coaches as parameters for the queue string
Refactorment:
Because of the circular dependency between the UserModel and SessionModel using the SessionModel in Queue was throwing an error: RefOptionIsUndefinedError: Prop-Option "ref"'s value is "null" or "undefined" for "User.sessions" [E005]
This is a known Typegoose Error which is mentioned here: https://typegoose.github.io/typegoose/docs/guides/advanced/reference-other-classes/#common-problems
I applied the recommended solution to solve this issue by providing a central models.ts file in which all models are loaded centrally. Thus all imports have to be adapted (thats why so many files have been changed : - ) )