bug: no way to identify why app installation failed

[ILoveOpenSourceApplications]

Type

Error at runtime

Bug description

There will be cases where one may be forced to uninstall the manager due to some issue and the user could have forgotten to backup the keystore. In such cases when updating a patched app over an existing patched app will end app with the message "app not installed as package conflicts with an existing package". But after the recent update and l presume with the fix #1021, when clicking install the pop up after installation just disappears. If installed successfully, the manager will say installed. But if it fails there is no way to know what's the issue and manager just says installing.

Steps to reproduce

1. Some how create a situation where the manager will come across a conflict (like mentioned above).
2. Try to install the same app over the existing one.
3. Normally there will the be conflict message but now you just sit there in the manager with unlimited install clicks.

Android version

Android 13

Manager version

1.4.1

Target package name

Any

Target package version.

Any

Installation type

Non-root

Patches selected.

Nil

Device logs (exported using Manager settings).

Nil

Installer logs (exported using Installer menu option) [unneeded if the issue is not during patching].

No response

Screenshots or video

screen-20230716-010252.2.mp4

Solution

No response

Additional context

No response

Acknowledgments

• I have searched the existing issues; this is new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I properly filled out all of the requested information in this issue.
• The issue is solely related to ReVanced Manager and not caused by patches.

[TheAabedKhan]

I am currently working on the fix. Can you please turn off the Google Play Protect for some times and try to install the app again and share me the results please?

[ILoveOpenSourceApplications]

I don't think it's due to play protect. But I did what you requested and turned of play protect and repeated the same with the results also being the same. Previously the manager would show a confirmation dialog which is part of the stock package installer. Now that it's removed there's no way of knowing what happened.

The package dialog I meant:

And similarly one the installation/update of an app is done that confirmation is also gone as well. Which is fine but feels odd as the users used to see that confirmation in the previous versions.

Edit: The confirmation dialog I meant which is still there:

The confirmation dialog I meant which is no longer there in manager:

[sssh7710]

The same happens to me when I install revanced

[sssh7710]

I'm uncomfortable because I don't know if the installation is in progress

[Ushie]

I think the callback should be removed if it's not possible to pop the dialog ONLY when it errors

The dialog needs to stay for two reasons:

• it natively contains an "Open" button to open the installed app
• currently, many installations fail because the dialog doesn't stay up long enough to show the play protect dialog

[KobeW50]

On a related note, the package installer dialog also does not appear when updating the Manager from within the Manager.

Movie001.mp4