-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube): Hide podcasts in the home feed #2663
Comments
Since the feed consists of the same components, you'd either hide the child component too late or be unable to distinguish between other feed items. The constructed view groups by Litho contain strings visible on the screen, which could technically be used to hide the views. |
A proto buffer filter likely would work, but currently the custom filter does not support that. But adding support would be fairly simple. The only question is how to present it in the settings, and figure out some kind of syntax to indicate a path and the protobuffer string that appear with the path. That could be as simple as using a $ or # character to separate the parts, ie: |
Sometimes we use abstract filter techniques such as checking first for the path, then for the buffer, or similar. In most cases, a simple buffer filter will be less than ideal |
I was referring to strings after the views being constructed. ViewGroups are nested and flattened Yoga artifacts from what I have understood, so you do can not edit say the text without rendering the ViewGroups again, but you can access the views and their children fairly granular as they resemble the same structure as the path builder string. Iirc calling toString on those views will sometimes return the string they are displaying so that would be a useful way to filter, even after the recursive method we currently hook that reads the protobuf stream to construct the ConversionContext pathbuilder |
What I meant was a syntax that filters if both the path and the buffer is found. Similar to how the action buttons and some other proto buffer elements are hidden. This would be only for custom filter, and yes it would be missing other techniques such as exclusionary filtering or 'starts with' checking. But something like this would work for some situations (and maybe a situation like this). |
Well I wouldn't mind too if the hide podcast will hide it altogether in other fields such as in any channel page or something like that, cause some people like me ever use that. Edit: btw additional info, this is not exclusive to like my revanced youtube account, this is also appearing from my regular youtube app, so I thought that eventually you guys would bump into this one way or another. |
I tried modifying custom filter to allow proto buffer filtering, and it does work without too much difficulty. I could not get the Podcast playlist to appear, so instead I tried filtering a specific channel from the search results. Here's a search result with a channel filtered using the path: This hides all videos from the channel named "Red Letter Media" but still allows all videos from other channels. The 'key moments' for some now hidden videos is still visible (explained more below): Unfiltered original search results Custom filter that removes RLM channel from search results Some limitations of allowing proto buffer strings in custom filter:
But at a minimum, allowing custom filter to filter the proto buffer works ok for trying out new filtering patch ideas before spending more time to create a polished dedicated patch. So it might be useful just for development purposes and maybe some advanced end users can also get some use out of it. |
Considering that, maybe a custom preference, similar to a list preference that takes two inputs, one for the path and one for strings and filters accordingly could be made later so that we don't need to use a custom string syntax. |
But is it possible to just outright hide podcast similar to mixes? |
I cannot say myself, because I cannot get any podcast mixes to show up in the home feed or search. |
I see, so we will just have to wait and see? |
Yes |
Okay that's reassuring thanks for looking this up too |
# [2.186.0-dev.2](ReVanced/revanced-patches@v2.186.0-dev.1...v2.186.0-dev.2) (2023-07-20) ### Bug Fixes * **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@96e3f68)) ### Features * **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@232b6f3))
# [2.186.0](ReVanced/revanced-patches@v2.185.0...v2.186.0) (2023-07-21) ### Bug Fixes * **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@6a3785a)) * **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@fbe55bf)) * **YouTube - Theme:** allow setting no background color ([8a4e77a](ReVanced/revanced-patches@d81e124)) * **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@96e3f68)) ### Features * **Twitter:** remove `Hide view stats` patch ([f0d3800](ReVanced/revanced-patches@e91ecb9)) * **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@232b6f3))
Custom filter now supports buffer (content) strings. This might work to hide the content: The downside is this will also hide all videos with 'Podcast' in the title or in the video channel name, which might make this unusable for some people. |
Hello @LisoUseInAIKyrios I tried the custom filter string to hide the podcast mix but it didn't work, although it did hide those videos or channel names with podcast in them but the mix playlist with podcast on them is still there in the homepage |
I can not see any podcasts on my end, so I'll need access to an account that does. Contact me at osumatrix@revanced.app |
My algorithm has changed so its not displaying some podcast as of now, can I contact you again if it ever appear so that I can lend you access to my account to inspect it? |
Yes, just reopen the issue once it comes up again, closing until then. |
# [2.186.0-dev.2](ReVanced/revanced-patches@v2.186.0-dev.1...v2.186.0-dev.2) (2023-07-20) ### Bug Fixes * **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@1f6fe3d)) ### Features * **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@5c39985))
# [2.186.0](ReVanced/revanced-patches@v2.185.0...v2.186.0) (2023-07-21) ### Bug Fixes * **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@b34e45b)) * **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@307442e)) * **YouTube - Theme:** allow setting no background color ([8a4e77a](ReVanced/revanced-patches@8a4e77a)) * **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@1f6fe3d)) ### Features * **Twitter:** remove `Hide view stats` patch ([f0d3800](ReVanced/revanced-patches@f0d3800)) * **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@5c39985))
Feature description
Just a simple option to hide podcast in the home feed
![Screenshot_2024_0129_195711](https://private-user-images.githubusercontent.com/126884197/300443803-69794475-d611-4e53-b2cc-04c549dfe140.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4MTY5MzEsIm5iZiI6MTcxOTgxNjYzMSwicGF0aCI6Ii8xMjY4ODQxOTcvMzAwNDQzODAzLTY5Nzk0NDc1LWQ2MTEtNGU1My1iMmNjLTA0YzU0OWRmZTE0MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwMVQwNjUwMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MjI5OTA1MjMxMTljNjZhZGQ5MzQwMDJjZGI4Njg3MTUxN2M3Y2ExMWQ3N2EzYjZjZTc2ZGY5ZWE1M2Y3ZDk4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.E-2R1NJeu2SQ4i0sizjUcl-g4VnUNhWe9WPtsPxfELI)
Motivation
Its kinda annoying to constantly see this type of playlist in the homepage, especially when I already got used to mixes being hidden
Acknowledgements
The text was updated successfully, but these errors were encountered: