Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Reddit crashing after being patched #2666

Closed
3 tasks done
Lenni-builder opened this issue Jan 29, 2024 · 5 comments
Closed
3 tasks done

bug: Reddit crashing after being patched #2666

Lenni-builder opened this issue Jan 29, 2024 · 5 comments
Labels
Bug report Something isn't working

Comments

@Lenni-builder
Copy link

Bug description

Reddit seems to crash when tapping on posts after patching it with ReVanced manager. I don't know which exact patch is causing this since I don't want to re-patch it multiple times (I had all available patches enabled)

screen-20240129-163007.mp4.2.mp4.2.mp4

Error logs

https://paste.crdroid.net/qEdATx

Solution

No response

Additional context

Reddit version: 2024.04.04, rooted install through ReVanced manager.

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Lenni-builder Lenni-builder added the Bug report Something isn't working label Jan 29, 2024
@oSumAtrIX
Copy link
Member

You must patch and mount a full APK, not a split

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
@Lenni-builder
Copy link
Author

You must patch and mount a full APK, not a split

It would be good if the patcher informed you about that.

@oSumAtrIX
Copy link
Member

Patching a split works in certain occasions, it would be incorrect to

@Lenni-builder
Copy link
Author

What about a warning instead of an error?

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jan 30, 2024 •
edited

ReVanced Patcher doesn't have any logic to check for splits, besides its not the purpose of ReVanced Patcher to warn you about that

Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.186.0-dev.4 [skip ci]
f769582 
# [2.186.0-dev.4](ReVanced/revanced-patches@v2.186.0-dev.3...v2.186.0-dev.4) (2023-07-20)

### Bug Fixes

* **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@fbe55bf))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.186.0 [skip ci]
245c6b5 
# [2.186.0](ReVanced/revanced-patches@v2.185.0...v2.186.0) (2023-07-21)

### Bug Fixes

* **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@6a3785a))
* **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@fbe55bf))
* **YouTube - Theme:** allow setting no background color ([8a4e77a](ReVanced/revanced-patches@d81e124))
* **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@96e3f68))

### Features

* **Twitter:** remove `Hide view stats` patch ([f0d3800](ReVanced/revanced-patches@e91ecb9))
* **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@232b6f3))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.186.0-dev.4 [skip ci]
dfb7d7b 
# [2.186.0-dev.4](ReVanced/revanced-patches@v2.186.0-dev.3...v2.186.0-dev.4) (2023-07-20)

### Bug Fixes

* **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@307442e))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.186.0 [skip ci]
f38982d 
# [2.186.0](ReVanced/revanced-patches@v2.185.0...v2.186.0) (2023-07-21)

### Bug Fixes

* **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@b34e45b))
* **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@307442e))
* **YouTube - Theme:** allow setting no background color ([8a4e77a](ReVanced/revanced-patches@8a4e77a))
* **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@1f6fe3d))

### Features

* **Twitter:** remove `Hide view stats` patch ([f0d3800](ReVanced/revanced-patches@f0d3800))
* **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@5c39985))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oSumAtrIX @Lenni-builder