feat: Add Change version code patch

[1fexd]

Adds a patch that sets an app's versionCode to 1, allowing apps to be downgraded since the versionCode is now constant

[LisoUseInAIKyrios]

What if an app is already installed but was not patched with this, can a downgraded version be installed with this?

If the version number needs to be the same or greater to to update, should this use max integer so it's always the same or 'newer' than whatever is already installed? If this is the case and this is done, the downside is this patch is always needed to upgrade any existing installation.

[oSumAtrIX]

I think the idea with this patch is always to use this patch when patching apps, so you can install any previously patched app as well.

[1fexd]

What if an app is already installed but was not patched with this, can a downgraded version be installed with this?

No

If the version number needs to be the same or greater to to update, should this use max integer so it's always the same or 'newer' than whatever is already installed? If this is the case and this is done, the downside is this patch is always needed to upgrade any existing installation.

You could do either the min or the max version code, where using the min one allows returning to the "real" version code, while the max would allow switching to this patch from an existing installation (already installed apps have to be signed with the ReVanced keys for both methods)

[1fexd]

I think the idea with this patch is always to use this patch when patching apps, so you can install any previously patched app as well.

Exactly

[oSumAtrIX]

The patch should be renamed to what it precisely does. In this case it changes the version code so the patch should be called "Change version code" similar to how the package name patch is called "Change package name". While the main side effect is to "Add app downgrading" in reality what the patch does is "Change version code"

[LisoUseInAIKyrios]

You could do either the min or the max version code, where using the min one allows returning to the "real" version code, while the max would allow switching to this patch from an existing installation (already installed apps have to be signed with the ReVanced keys for both methods)

It seems using max integer version would be more immediate for what the goal is (downgrade an existing installation), since it can patch and downgrade in one go regardless how the existing app was previously patched and installed (only requirement is the user patched themselves and has the same signing key).

Using version 1 does not allow downgrading an existing installation that did not originally include this patch, meaning for that install it's impossible to downgrade unless uninstalled first (and then this patch is not required).

Maybe the version number can be exposed as a patch option, but that might be way more complicated than needed.

[LisoUseInAIKyrios]

I am not sure, but I think if the version code is max integer, that will effectively turn off Google play store updates since the existing installation will always show as 'newer' than whatever the play store has.

[1fexd]

You could do either the min or the max version code, where using the min one allows returning to the "real" version code, while the max would allow switching to this patch from an existing installation (already installed apps have to be signed with the ReVanced keys for both methods)

It seems using max integer version would be more immediate for what the goal is (downgrade an existing installation), since it can patch and downgrade in one go regardless how the existing app was previously patched and installed (only requirement is the user patched themselves and has the same signing key).

Using version 1 does not allow downgrading an existing installation that did not originally include this patch, meaning for that install it's impossible to downgrade unless uninstalled first (and then this patch is not required).

Maybe the version number can be exposed as a patch option, but that might be way more complicated than needed.

Done, defaults to the Google Play maxium (https://developer.android.com/studio/publish/versioning)

[oSumAtrIX]

I don't think restricting to Google Play's maximum makes sense. In terms of Android, the integer max value can be used, so why not here?

[1fexd]

Done

[1fexd]

Anything else left to do here @oSumAtrIX?

[ILoveOpenSourceApplications]

Can Change version code be understandable to everyone, as in what it does? What about Change app version, which I believe most will be able to understand much easily.

[LisoUseInAIKyrios]

'App version' usually refers to the user facing version the app presents itself as, such as 19.11.39, while the version code is the internal (not publicly facing) version used to compare against other releases.

[cyberboh]

This patch seems does not support widely
I tested with Instagram 332.0.0.38.90 error while compiling.
The log, maybe does not supported by current AAPT

INFO: Compiling modified resources
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-h640dp\layouts.xml:3: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-h640dp\layouts.xml: error: file failed to compile.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-land\layouts.xml:3: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-land\layouts.xml:4: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-land\layouts.xml:5: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-land\layouts.xml:6: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-land\layouts.xml:7: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-land\layouts.xml: error: file failed to compile.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-sw600dp\layouts.xml:3: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-sw600dp\layouts.xml:4: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values-sw600dp\layouts.xml: error: file failed to compile.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:3: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:4: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:5: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:6: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:7: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:8: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:9: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:10: error: invalid value for type 'layout'. Expected a reference.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res\values\layouts.xml:11: error: invalid value for type 'layout'. Expected a reference.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\User\AppData\Local\Temp\brut_util_Jar_128283882703127182132429529068672218130.tmp, compile, --dir, E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res, --legacy, -o, E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\build\resources.zip]
        at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:123)
        at brut.androlib.AaptInvoker.invokeAapt(AaptInvoker.java:394)
        at app.revanced.patcher.data.ResourceContext.get(ResourceContext.kt:134)
        at app.revanced.patcher.Patcher.get(Patcher.kt:268)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:312)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\User\AppData\Local\Temp\brut_util_Jar_128283882703127182132429529068672218130.tmp, compile, --dir, E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\res, --legacy, -o, E:\ANDROID\APPS\ReVanced\Patched\Install\Instagram_332.0.0.38.90-arm64-v8a_360-480_dpi_ReVanced-temporary-files\patcher\apk\build\resources.zip]
        at brut.util.OS.exec(OS.java:104)
        at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:119)
        ... 13 more

[1fexd]

That's probably an Instagram issue as they do a lot of weird stuff with their apks to try to make reverse engineering harder

[oSumAtrIX]

This is not an issue with the patch but resource decompilation/AAPT.

[cyberboh]

Sigh , AAPT again, hopefully it solved in near future.