feat(Instagram): Add Hide ads patch

[tymmesyde]

Hide Instagram ads

[oSumAtrIX]

Is this a general ad injector or only for profiles?

[tymmesyde]

General injector

[oSumAtrIX]

Is the previous timeline ads patch necessary then?

[tymmesyde]

I don't think so, i wanted to ask if i should remove it ?

[oSumAtrIX]

That makes sense. Are reel ads included? If not, it may be good to add a description to explain what kind of ads are hidden.

[tymmesyde]

Yes, stories, discover, profile etc..
The only place that i could still find some is when you reload your timeline by pulling the top, an ad can get injected in the first post

[oSumAtrIX]

I believe the current timeline ads patch does hide that. Perhaps combining both patches makes sense? The only issue would be that the patch would be constrained to some older version. The alternative would be to note this behaviour in the description

[tymmesyde]

I will add this behavior in the description

[welcome]

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

[cyberboh]

INFO: Hide ads succeeded
SEVERE: Hide timeline ads failed:
app.revanced.patcher.patch.PatchException: Failed to resolve ShowAdFingerprint
        at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:27)
        at app.revanced.patches.instagram.patches.ads.timeline.HideTimelineAdsPatch.execute(HideTimelineAdsPatch.kt:61)
        at app.revanced.patches.instagram.patches.ads.timeline.HideTimelineAdsPatch.execute(HideTimelineAdsPatch.kt:16)
        at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:173)
        at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:205)
        at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
        at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
        at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
        at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
        at app.revanced.cli.command.PatchCommand$run$4$1$1.invokeSuspend(PatchCommand.kt:303)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:302)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

What's the benefit keeping both patches?
If Hide timeline ads already replaced by Hide ads, you should remove broken patches

[oSumAtrIX]

Refer to #3380 (comment)

[cyberboh]

Refer to #3380 (comment)

In the descriptions:
description = "Hides ads in stories, discover, profile, etc."
Is that different from Hide timeline ads does?

[tymmesyde]

Refer to #3380 (comment)

In the descriptions: description = "Hides ads in stories, discover, profile, etc." Is that different from Hide timeline ads does?

Yes, the previous patch only hid ads on the home feed
This one hides them almost everywhere

[cyberboh]

Refer to #3380 (comment)

In the descriptions: description = "Hides ads in stories, discover, profile, etc." Is that different from Hide timeline ads does?

Yes, the previous patch only hid ads on the home feed This one hides them almost everywhere

As I thought before.
So, Hide timeline ads patch should be removed in favor of Hide ads patch.
May be you can make a PR for it.

[ani9730]

What version of instagram is this tested on ?

[oSumAtrIX]

Latest

[cyberboh]

@Neon329 See my comment above you. That patch should be removed because already replaced by Hide ads. Exclude it and it will work.

[vsavovski]

Last working version v339.0.0.30.105, version v340.0.0.22.109 fails.