Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Patch for a fixed domain of XDA app (XDA Forums) #2607

Closed
3 tasks done
giwrgosmant opened this issue Jan 10, 2024 · 14 comments
Closed
3 tasks done

feat: Patch for a fixed domain of XDA app (XDA Forums) #2607

giwrgosmant opened this issue Jan 10, 2024 · 14 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@giwrgosmant
Copy link

giwrgosmant commented Jan 10, 2024

Feature description

I would like to suggest, if possible to create a patch to fix the domain of XDA app (package name: com.xda.labs.play)
Few months ago, XDA-Valnet changed the domain from xda-developers to xdaforums and that broke the XDA app. Users cannot login/use the app since then, so it became useless. The devs of that app seems they abandoned it long ago but at least it was working fine till that change happened.
A patch for a fix would be great.
Full details: here.

Motivation

  • It will make the XDA app useful and working again.
  • XDA users will be able to get push notifications / communicate fast into the XDA Forums.
  • More advantages of a working XDA app: here.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@giwrgosmant giwrgosmant added the Feature request Requesting a new feature that's not implemented yet label Jan 10, 2024
@oSumAtrIX
Copy link
Member

As I understood this, only a domain name string change is needed?

@giwrgosmant
Copy link
Author

As I understood this, only a domain name string change is needed?

yeap.

@oSumAtrIX
Copy link
Member

Should be possible by using the abstract instruction transformer patch, or if only one string reference, via a regular fingerprint

@oSumAtrIX
Copy link
Member

Could add a generic string transformer patch to ReVanced which would be able to transform a list of strings to another

@cyberboh
Copy link

Is this application still under development? I mean, why not contact the developer to improve it? I saw on the Play Store that it was last updated in 2021 and has a rating of 2.9. I would suggest using another app, like Tapatalk. At least it has good rating (4.3) and still in development (last update was Dec 28, 2023)

@giwrgosmant
Copy link
Author

Is this application still under development? I mean, why not contact the developer to improve it? I saw on the Play Store that it was last updated in 2021 and has a rating of 2.9. I would suggest using another app, like Tapatalk. At least it has good rating (4.3) and still in development (last update was Dec 28, 2023)

I explain everything on the thread.
XDA is now owned by Valnet and they gave the "development" of that app to Audentio, however none seems to care about that app anymore. We've already asked admins to contact them but idk what's going on, we don't have any news by their side (company).
The app was working good until the change in domain happened. For push notifications/fast communication and browse it's perfectly fine, there is no good alternative atm.

@oSumAtrIX
Copy link
Member

Neither login nor the app is broken:

image

@giwrgosmant
Copy link
Author

giwrgosmant commented Jan 10, 2024

Neither login nor the app is broken:

image

If you try to login you will stay logged in the browser window instead of the app. The app should redirect to a browser window you see now, put pass, authorize the app, redirect back to the app logged in.
The last (authorize the app and redirect back to the app logged in) doesn't happen.

@oSumAtrIX
Copy link
Member

I am locally testing my patches, and as far as I can tell, the redirect uri for the oauth has to be changed. Mind that once the client id is shut off by xda, the oauth will fail.

@giwrgosmant
Copy link
Author

giwrgosmant commented Jan 10, 2024

@oSumAtrIX a fixed modded version of the app released by an xda Recognized Developer into the xda forum thread (not officially on Play Store tho) according the recent statement by the admin.

So in the light of recent news, I don't know if the patch is needed anymore, however if you already started working on it and you are about to finish, there is no harm for us as users, to have that solution available too.

I just wanted to inform you.

@oSumAtrIX
Copy link
Member

Technically, an open-source patch is more transparent than a modded apk, but since the modded apk already satisfies the folks on your end, I'll close this; thanks.

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
@giwrgosmant
Copy link
Author

Technically, an open-source patch is more transparent than a modded apk, but since the modded apk already satisfies the folks on your end, I'll close this; thanks.

I agree, however since a modded working app is now released I wanted to notify you and let the decision on you.
I personally want to have an alternative revanced solution but I don't want to put an extra work on you since it's not priority anymore.
Feel free to include or not that patch as you wish.

@oSumAtrIX
Copy link
Member

If possible, please ask the modder for more information on what changes were made to simplify the development of the patch. Reopen the issue once you have

@giwrgosmant
Copy link
Author

If possible, please ask the modder for more information on what changes were made to simplify the development of the patch. Reopen the issue once you have

I asked the dev about it and he can help with the patch. However he is off till weekend and he asked me how he can contact you in private.

Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.185.0-dev.7](ReVanced/revanced-patches@v2.185.0-dev.6...v2.185.0-dev.7) (2023-07-19)

### Bug Fixes

* **YouTube - Spoof client:** show video time and chapters while using seekbar ([ReVanced#2607](ReVanced/revanced-patches#2607)) ([9546d12](ReVanced/revanced-patches@da2a216))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.185.0](ReVanced/revanced-patches@v2.184.0...v2.185.0) (2023-07-20)

### Bug Fixes

* allocate for more than eight `LithoFilter` array items ([ReVanced#2643](ReVanced/revanced-patches#2643)) ([fc8660b](ReVanced/revanced-patches@2d8e15b))
* **Sync for Reddit - Disable ads:** fix compatibility with latest version ([1456577](ReVanced/revanced-patches@1275a93))
* **Tiktok - Settings:** bump compatibility ([ReVanced#2656](ReVanced/revanced-patches#2656)) ([6641356](ReVanced/revanced-patches@fbc5c7d))
* **TikTok - Show seekbar:** fix seekbar not always showing ([ReVanced#2660](ReVanced/revanced-patches#2660)) ([f2742f1](ReVanced/revanced-patches@5a16231))
* **Trakt - Unlock pro:** constraint to last known working version ([ReVanced#2662](ReVanced/revanced-patches#2662)) ([324bbde](ReVanced/revanced-patches@84fa088))
* **YouTube - Spoof client:** show video time and chapters while using seekbar ([ReVanced#2607](ReVanced/revanced-patches#2607)) ([9546d12](ReVanced/revanced-patches@da2a216))
* **youtube/sponsorblock:** fix some segments skipping slightly too late ([ReVanced#2634](ReVanced/revanced-patches#2634)) ([3175431](ReVanced/revanced-patches@73dd87f))

### Features

* **youtube:** rename `video-speed` to `playback-speed` ([ReVanced#2642](ReVanced/revanced-patches#2642)) ([77e8639](ReVanced/revanced-patches@fde251d))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.185.0-dev.7](ReVanced/revanced-patches@v2.185.0-dev.6...v2.185.0-dev.7) (2023-07-19)

### Bug Fixes

* **YouTube - Spoof client:** show video time and chapters while using seekbar ([ReVanced#2607](ReVanced/revanced-patches#2607)) ([9546d12](ReVanced/revanced-patches@9546d12))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.185.0](ReVanced/revanced-patches@v2.184.0...v2.185.0) (2023-07-20)

### Bug Fixes

* allocate for more than eight `LithoFilter` array items ([ReVanced#2643](ReVanced/revanced-patches#2643)) ([fc8660b](ReVanced/revanced-patches@fc8660b))
* **Sync for Reddit - Disable ads:** fix compatibility with latest version ([1456577](ReVanced/revanced-patches@1456577))
* **Tiktok - Settings:** bump compatibility ([ReVanced#2656](ReVanced/revanced-patches#2656)) ([6641356](ReVanced/revanced-patches@6641356))
* **TikTok - Show seekbar:** fix seekbar not always showing ([ReVanced#2660](ReVanced/revanced-patches#2660)) ([f2742f1](ReVanced/revanced-patches@f2742f1))
* **Trakt - Unlock pro:** constraint to last known working version ([ReVanced#2662](ReVanced/revanced-patches#2662)) ([324bbde](ReVanced/revanced-patches@324bbde))
* **YouTube - Spoof client:** show video time and chapters while using seekbar ([ReVanced#2607](ReVanced/revanced-patches#2607)) ([9546d12](ReVanced/revanced-patches@9546d12))
* **youtube/sponsorblock:** fix some segments skipping slightly too late ([ReVanced#2634](ReVanced/revanced-patches#2634)) ([3175431](ReVanced/revanced-patches@3175431))

### Features

* **youtube:** rename `video-speed` to `playback-speed` ([ReVanced#2642](ReVanced/revanced-patches#2642)) ([77e8639](ReVanced/revanced-patches@77e8639))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants