Add linear wrapper and kan feedback #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents division by zero. This appears to be the reason for the initial instability of inference, so now we can explore various KAN applications. Note: We should convert this clamp into an argparse param and config for experimentation.
This allows us to set the mean and standard deviation for random weights for both linear modules and for the embedding table.
After experimentation, we don't need to include these after including the dictionary.
Utilize inheritance based interface adaptation.
Closed
|
Previous discussions here: |
After these changes wpe is not set if we're using a different strategy for position embedding.
gkielian
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.