Feature/axe a11y critical issues #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-finland processing. Built with commit e47d388 https://app.netlify.com/sites/react-finland/deploys/5c0ec67740e2a47254c33928 |
|
Great, thanks. Maybe we skip |
|
The the zooming has been disabled before this and stil now on. (Uups I mentioned to comment with the part ’maximum-scale= 1.0’ that is same as the initial.) I could test and make another PR for the zooming to be enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not taking a stance on how the mobile should be zoomable or not (and how it would look like):
initial-scale=1.0, minimum-scale=1.0Closes #27