Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCRIPT16389: Unspecified error. IE <=11 on page refresh #289

Merged
merged 1 commit into from
May 26, 2016
Merged

Fix SCRIPT16389: Unspecified error. IE <=11 on page refresh #289

merged 1 commit into from
May 26, 2016

Conversation

kirylkastko
Copy link

The author of this PR #230 didn't fix a conflict. I decided to create a new a new PR. Really need this fix to be merged.

If there is no browser history in the window in IE11 the window.history.state throws an unspecified error. Wrap in try catch.
@taion
Copy link
Contributor

taion commented May 5, 2016

Same question as before – is there any way you could make add a regression test?

@kirylkastko
Copy link
Author

I'll try.

@mjackson
Copy link
Member

mjackson commented May 6, 2016

@kirillkostko Can you at least give me any more information as to why IE11 throws here? Is it throwing when we access window.history inside an <iframe>? Or window.history.state?

@kirylkastko
Copy link
Author

It happened when I started my React app, not inside iframe. When we access window.history.state, IE throws this error.

@kirylkastko
Copy link
Author

@mjackson Hi, have you found something?

@laurel-taylor
Copy link

laurel-taylor commented May 16, 2016

I'm also getting this error inside a react app with IE11..

As a workaround, I've put the following in the html page, and it seems to be working:

<!--[if IE 11]>
 <script>
  window.history.state = {};
 </script>
<![endif]-->

@cloudkite
Copy link

@mjackson, @taion angular also wraps accessing window.history.state for the same reasons
angular/angular.js@3b8163b

@mjackson mjackson merged commit 96ee249 into remix-run:v2.x May 26, 2016
mjackson added a commit that referenced this pull request May 26, 2016
@mjackson
Copy link
Member

Just FYI everyone, this fix was released in version 2.1.2.

@kirylkastko
Copy link
Author

@mjackson Thank you very much! 😄

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants