fix(react): Add missing arShadowReceiver prop #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexttyip
force-pushed
the
ar-shadow-receiver
branch
from
5cb079d
to
3dd74f8
Compare
cjmcassar
approved these changes
May 9, 2024
cjmcassar
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation for ViroQuad and ViroPolygon, they should have an
arShadowReceiverprop to determine if the component should act as a transparent surface and capture any shadows that are cast onto it.This, however, is missing from the prop types of the two components, which means TypeScript errors when the components are used with that prop.
This PR adds the prop to the prop type definitions of the two components.