Generate resonance structures before checking molecule isomorphism #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In converter, generate resionance structures of copies of mol1 and mol2 by making them RMG:Species objects, then check isomorphism
instead of isIsomorphic()
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 40.86% 40.87% +<.01%
==========================================
Files 22 22
Lines 4965 4969 +4
Branches 1285 1284 -1
==========================================
+ Hits 2029 2031 +2
+ Misses 2609 2607 -2
- Partials 327 331 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 40.86% 40.87% +<.01%
==========================================
Files 22 22
Lines 4965 4969 +4
Branches 1285 1284 -1
==========================================
+ Hits 2029 2031 +2
+ Misses 2609 2607 -2
- Partials 327 331 +4
Continue to review full report at Codecov.
|
alongd
force-pushed
the
fix_isomorphism
branch
2 times, most recently
from
e860bad
to
4261af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to converter. Also first copy the molecule not to change original atom order.