Fixed typo and wrong SMILES in solute library #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typos in some solutes' names and fixed wrong SMILES of two solutes in input/solvation/libraries/solute.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some minor typos in solutes' names in
input/solvation/libraries/solute.pyand fixed them.I also found two solutes with wrong SMILES, meaning that their SMILES do not match the names of the solutes. To double-check that it is the SMILES that are wrong not the labels, I compared the values of the solute parameters in
input/solvation/libraries/solute.pyto those I found in literature. This confirmed that the labels of these two solutes are right and SMILES were wrong, so I fixed the SMILES to those that match with their labels.