Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RxJava 3 #540

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Update to RxJava 3 #540

merged 3 commits into from
Sep 6, 2019

Conversation

drewhamilton
Copy link
Contributor

@drewhamilton drewhamilton commented Sep 2, 2019

Closes #538.

With RxJava 3.0.0-RC2, the package names of all RxJava types were changed. This PR updates all the imports in RxAndroid accordingly.

If the intention is to update RxAndroid's package names as well I'm happy to add that to this PR.

This shouldn't actually be merged to 2.x, there just isn't a 3.x to point to yet.

Update to RxJava 3.0.0-RC2
Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd also want to change the package names of this library so RxAndroid 2.x and 3.x can live side by side

@JakeWharton JakeWharton changed the base branch from 2.x to 3.x September 3, 2019 18:00
@drewhamilton
Copy link
Contributor Author

@vanniktech @JakeWharton io.reactive.rxjava3.android.**?

Also: Should MainThreadDisposable be moved to a disposables package to align with RxJava's packaging conventions?

@JakeWharton
Copy link
Contributor

Since we offer dramatically less API surface, we don't need the same package layering.

That package seems like the right one to me.

@JakeWharton JakeWharton merged commit 64055e2 into ReactiveX:3.x Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants