We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Calling BufferWithTimeOrCount can result in larger buffers being emitted.
BufferWithTimeOrCount
To Reproduce The following test always seems to fail
func TestBufferWithTimeOrCountDoesNotExceedBufferSize(t *testing.T){ observable := rxgo.Just(1,2,3)() buffers := observable.BufferWithTimeOrCount(rxgo.WithDuration(time.Second), 1) rxgo.Assert(context.Background(), t, buffers, rxgo.HasItems([]interface{}{1}, []interface{}{2}, []interface{}{3})) }
The following test will intermittently fail. On my machine, I find a fail occurs on most runs if I run with go test -count 10000
go test -count 10000
func TestBufferWithTimeOrCountDoesNotExceedBufferSizeOf2(t *testing.T){ observable := rxgo.Just(1,2,3,4,5)() buffers := observable.BufferWithTimeOrCount(rxgo.WithDuration(time.Second), 2) rxgo.Assert(context.Background(), t, buffers, rxgo.HasItems([]interface{}{1,2}, []interface{}{3,4}, []interface{}{5})) }
Expected behavior Buffer sizes should never exceed the count passed
Additional context
The text was updated successfully, but these errors were encountered:
Fixed in PR #289
Sorry, something went wrong.
teivah
No branches or pull requests
Describe the bug
Calling
BufferWithTimeOrCount
can result in larger buffers being emitted.To Reproduce
The following test always seems to fail
The following test will intermittently fail. On my machine, I find a fail occurs on most runs if I run with
go test -count 10000
Expected behavior
Buffer sizes should never exceed the count passed
Additional context
The text was updated successfully, but these errors were encountered: