fix(typings): fix subscribe overloads (#3053)

cartant · benlesh · commit 1a9fd42c7bd0 · 2017-12-01T14:58:42.000-08:00
Remove the no-arg overload. If not removed, any Observable will be compatible with any ObservableInput regardless of type - as T does not appear in the no-arg overload. Closes #3052
diff --git a/src/Observable.ts b/src/Observable.ts
@@ -73,8 +73,7 @@ export class Observable<T> implements Subscribable<T> {
     return observable;
   }
 
-  subscribe(): Subscription;
-  subscribe(observer: PartialObserver<T>): Subscription;
+  subscribe(observer?: PartialObserver<T>): Subscription;
   subscribe(next?: (value: T) => void, error?: (error: any) => void, complete?: () => void): Subscription;
   /**
    * Invokes an execution of an Observable and registers Observer handlers for notifications it will emit.

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,7 @@ export class Observable<T> implements Subscribable<T> {`
`73`	`73`	`return observable;`
`74`	`74`	`}`
`75`	`75`
`76`		`- subscribe(): Subscription;`
`77`		`- subscribe(observer: PartialObserver<T>): Subscription;`
	`76`	`+ subscribe(observer?: PartialObserver<T>): Subscription;`
`78`	`77`	`subscribe(next?: (value: T) => void, error?: (error: any) => void, complete?: () => void): Subscription;`
`79`	`78`	`/**`
`80`	`79`	`* Invokes an execution of an Observable and registers Observer handlers for notifications it will emit.`