Skip to content

Commit 7f67b09

Browse files
committed
fix(test): make explicit unsubscription for observable
1 parent fc3dcf7 commit 7f67b09

File tree

4 files changed

+18
-9
lines changed

4 files changed

+18
-9
lines changed

spec/observables/fromEventPattern-spec.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,12 @@ describe('Observable.fromEventPattern', function () {
6161
return a + b + '!';
6262
};
6363

64-
Observable.fromEventPattern(addHandler, removeHandler, selector)
64+
Observable.fromEventPattern(addHandler, removeHandler, selector).take(1)
6565
.subscribe(function (x) {
6666
expect(x).toBe('testme!');
67-
done();
68-
});
67+
}, function (e) {
68+
done.fail('should not be called');
69+
}, done);
6970

7071
trigger('test', 'me');
7172
});
@@ -89,10 +90,13 @@ describe('Observable.fromEventPattern', function () {
8990
};
9091

9192
Observable.fromEventPattern(addHandler, removeHandler, selector)
92-
.subscribe(function () { },
93-
function (err) {
93+
.subscribe(function (x) {
94+
done.fail('should not be called');
95+
}, function (err) {
9496
expect(err).toBe('bad');
9597
done();
98+
}, function () {
99+
done.fail('should not be called');
96100
});
97101

98102
trigger('test');

spec/observables/of-spec.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ describe('Observable.of', function () {
5050
Observable.of(42).subscribe(function (x) {
5151
expect(++calls).toBe(1);
5252
expect(x).toBe(42);
53-
done();
54-
});
53+
}, function (x) {
54+
done.fail('should not be called');
55+
}, done);
5556
});
5657

5758
it('should handle an Observable as the only value', function () {

spec/observables/range-spec.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe('Observable.range', function () {
1212
expect(results).toEqual([12, 13, 14, 15]);
1313
});
1414

15-
it('should accept a scheduler' , function (done) {
15+
it('should accept a scheduler', function (done) {
1616
var expected = [12, 13, 14, 15];
1717
spyOn(asap, 'schedule').and.callThrough();
1818

@@ -24,7 +24,9 @@ describe('Observable.range', function () {
2424
expect(asap.schedule).toHaveBeenCalled();
2525
var exp = expected.shift();
2626
expect(x).toBe(exp);
27-
}, done.throw, done);
27+
}, function (x) {
28+
done.fail('should not be called');
29+
}, done);
2830
});
2931
});
3032

spec/subjects/replay-subject-spec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ describe('ReplaySubject', function () {
167167
expect(results1).toEqual([3,4,5,6,7]);
168168
expect(results2).toEqual([4,5,6,7,8]);
169169
expect(results3).toEqual([9,10,11]);
170+
171+
subject.complete();
170172
});
171173
});
172174

0 commit comments

Comments
 (0)