Skip to content

Commit b981666

Browse files
committed
feat(reorganize): hid testing implementation details
BREAKING CHANGE: `HotObservable` and `ColdObservable`, and other testing support types are no longer exported directly.
1 parent 810c4d0 commit b981666

File tree

12 files changed

+32
-23
lines changed

12 files changed

+32
-23
lines changed

spec/helpers/marble-testing.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { Observable } from '../../src/Observable';
2-
import { SubscriptionLog } from '../../src/testing/SubscriptionLog';
3-
import { ColdObservable } from '../../src/testing/ColdObservable';
4-
import { HotObservable } from '../../src/testing/HotObservable';
5-
import { TestScheduler, observableToBeFn, subscriptionLogsToBeFn } from '../../src/testing/TestScheduler';
2+
import { SubscriptionLog } from '../../src/internal/testing/SubscriptionLog';
3+
import { ColdObservable } from '../../src/internal/testing/ColdObservable';
4+
import { HotObservable } from '../../src/internal/testing/HotObservable';
5+
import { TestScheduler, observableToBeFn, subscriptionLogsToBeFn } from '../../src/internal/testing/TestScheduler';
66

77
declare const global: any;
88

spec/observables/generate-spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as Rx from '../../src/Rx';
22
import '../../src/add/observable/generate';
3-
import { TestScheduler } from '../../src/testing/TestScheduler';
3+
import { TestScheduler } from '../../src/internal/testing/TestScheduler';
44
import { expect } from 'chai';
55
declare const {asDiagram, expectObservable};
66
declare const rxTestScheduler: TestScheduler;

spec/subjects/ReplaySubject-spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { expect } from 'chai';
22
import * as Rx from '../../src/Rx';
3-
import { TestScheduler } from '../../src/testing/TestScheduler';
3+
import { TestScheduler } from '../../src/internal/testing/TestScheduler';
44
import marbleTestingSignature = require('../helpers/marble-testing'); // tslint:disable-line:no-require-imports
55

66
declare const hot: typeof marbleTestingSignature.hot;

spec/testing/index-spec.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import * as index from '../../src/testing/index';
2+
import { expect } from 'chai';
3+
4+
describe('index', () => {
5+
it('should export TestScheduler', () => {
6+
expect(index.TestScheduler).to.exist;
7+
});
8+
});

src/Rx.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ export {TimeoutError} from './util/TimeoutError';
159159
export {UnsubscriptionError} from './util/UnsubscriptionError';
160160
export {TimeInterval} from './internal/patching/operator/timeInterval';
161161
export {Timestamp} from './internal/operators/timestamp';
162-
export {TestScheduler} from './testing/TestScheduler';
162+
export {TestScheduler} from './internal/testing/TestScheduler';
163163
export {VirtualTimeScheduler} from './internal/scheduler/VirtualTimeScheduler';
164164
export {AjaxRequest, AjaxResponse, AjaxError, AjaxTimeoutError} from './internal/observable/dom/AjaxObservable';
165165
export { pipe } from './util/pipe';

src/testing/ColdObservable.ts renamed to src/internal/testing/ColdObservable.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { Observable } from '../internal/Observable';
2-
import { Subscription } from '../internal/Subscription';
3-
import { Scheduler } from '../internal/Scheduler';
1+
import { Observable } from '../Observable';
2+
import { Subscription } from '../Subscription';
3+
import { Scheduler } from '../Scheduler';
44
import { TestMessage } from './TestMessage';
55
import { SubscriptionLog } from './SubscriptionLog';
66
import { SubscriptionLoggable } from './SubscriptionLoggable';
7-
import { applyMixins } from '../util/applyMixins';
8-
import { Subscriber } from '../internal/Subscriber';
7+
import { applyMixins } from '../../util/applyMixins';
8+
import { Subscriber } from '../Subscriber';
99

1010
/**
1111
* We need this JSDoc comment for affecting ESDoc.

src/testing/HotObservable.ts renamed to src/internal/testing/HotObservable.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { Subject } from '../internal/Subject';
2-
import { Subscriber } from '../internal/Subscriber';
3-
import { Subscription } from '../internal/Subscription';
4-
import { Scheduler } from '../internal/Scheduler';
1+
import { Subject } from '../Subject';
2+
import { Subscriber } from '../Subscriber';
3+
import { Subscription } from '../Subscription';
4+
import { Scheduler } from '../Scheduler';
55
import { TestMessage } from './TestMessage';
66
import { SubscriptionLog } from './SubscriptionLog';
77
import { SubscriptionLoggable } from './SubscriptionLoggable';
8-
import { applyMixins } from '../util/applyMixins';
8+
import { applyMixins } from '../../util/applyMixins';
99

1010
/**
1111
* We need this JSDoc comment for affecting ESDoc.

src/testing/SubscriptionLoggable.ts renamed to src/internal/testing/SubscriptionLoggable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Scheduler } from '../internal/Scheduler';
1+
import { Scheduler } from '../Scheduler';
22
import { SubscriptionLog } from './SubscriptionLog';
33

44
export class SubscriptionLoggable {

src/testing/TestMessage.ts renamed to src/internal/testing/TestMessage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Notification } from '../internal/Notification';
1+
import { Notification } from '../Notification';
22

33
export interface TestMessage {
44
frame: number;

0 commit comments

Comments
 (0)