chore(DeferObservable): add benchmarks & minor perf

[tetsuharuohzeki]

This is the benchmark result on Node v5.9.0,
MacBook Pro (Retina, 15-inch, Mid 2014, 2.8 GHz Intel Core i7, 16 GB 1600 MHz DDR3).

Before (7116d1d)

                                         |                     RxJS 4.1.0 |              RxJS 5.0.0-beta.3 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
                       defer - immediate |             1,117,475 (±1.08%) |             1,979,565 (±1.09%) |           1.77x |           77.1%
                                   defer |               905,413 (±1.15%) |             1,187,348 (±1.42%) |           1.31x |           31.1%

After changeset 09cd8d0

                                         |                     RxJS 4.1.0 |              RxJS 5.0.0-beta.3 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
                       defer - immediate |             1,070,341 (±0.96%) |             2,003,761 (±1.21%) |           1.87x |           87.2%
                                   defer |               944,100 (±1.30%) |             1,234,359 (±1.25%) |           1.31x |           30.7%

After changeset 70c3247

                                         |                     RxJS 4.1.0 |              RxJS 5.0.0-beta.3 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
                       defer - immediate |             1,058,502 (±1.15%) |             2,035,010 (±1.06%) |           1.92x |           92.3%
                                   defer |               914,642 (±1.26%) |             1,219,651 (±1.89%) |           1.33x |           33.3%

[benlesh]

Can you try adding this as a member of DeferObservable? That way you don't create a closure in _subscribe to get at callObservableFactory. It probably won't make a huge difference, but I wanted to bring it up.

[tetsuharuohzeki]

Can you try adding this as a member of DeferObservable?

okay. there is no regression after doing it.

                                         | RxJS 5.0.0-beta.2 |
----------------------------------------------------------------
                       defer - immediate | 2,440,423 (±0.54%) |
                                   defer | 1,471,945 (±0.44%) |

[kwonoj]

@saneyuki , appreciate for effort. Recent changes in defer to support promise as well includes changes for this PR of remove tryCatch (0cb44e1) - would you mind update this PR for benchmark test?

[tetsuharuohzeki]

@kwonoj

I updated this pull request and the description.

[benlesh]

@saneyuki, can you flatten the last two commits?

[benlesh]

Adding "Blocked" until the last two commits are flattened, Then it's good to go. Attn @kwonoj

[kwonoj]

I'll keep eye on this. 👀

[tetsuharuohzeki]

@kwonoj squashed!

[kwonoj]

I tried this before check in, seeing results as below

 defer |     659,651 (±1.48%) |     603,249 (±1.83%) |      0.91x |     -8.6%

I've been experienced sometimes number shows differently on my machine only and maybe this is same cases, but would like to confirm once again. @saneyuki , would you mind provide number again with latest changes?

[tetsuharuohzeki]

@kwonoj

This is the newly benchmark result (the based master is ec4f2b7)

---

Environment

• Node v5.10.1
• OSX 10.11.4
• MacBook Pro (Retina, 15-inch, Mid 2014)
  • CPU: 2.8 GHz Intel Core i7
  • RAM: 16 GB 1600 MHz DDR3

Result

Before

                                         |                     RxJS 4.1.0 |              RxJS 5.0.0-beta.5 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
                       defer - immediate |             1,010,478 (±1.09%) |             1,537,480 (±1.37%) |           1.52x |           52.2%
                                   defer |               874,775 (±1.34%) |               969,339 (±1.62%) |           1.11x |           10.8%

After

                                         |                     RxJS 4.1.0 |              RxJS 5.0.0-beta.5 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
                       defer - immediate |             1,049,825 (±0.74%) |             1,595,495 (±1.33%) |           1.52x |           52.0%
                                   defer |               843,224 (±1.18%) |               997,643 (±1.33%) |           1.18x |           18.3%

[kwonoj]

Merged with 566f46b, thanks @saneyuki for confirmation. Seems it's my machine again.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.