-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Observable): introduce Subscribable interface to use instead of Observable in input arguments #1475
Conversation
…nstead of Observable in input
This sounds like a better change. How do the builds perform with this change? |
Also, for my own reference, this is semi-related to #1463 .. but only in the typings aspect. |
Perf is roughly on par with tag properties |
@Blesh can you please tell if there is anything else that needs to be done on this PR? |
@vladima sorry, I've been sick and busy catching up from being sick... |
This LGTM. |
Great! Does it mean that it will be available in the next beta release of RxJS? |
: I believe so. I'll double check and check this in around today or tomorrow, can be in time before next release freeze hits. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
public surface of
Subscribable
is much smaller than inObservable
which significantly reduces space to explore in when doingtype-related-to
checks in TypeScript compiler.