Skip to content

fix(Observable): introduce Subscribable interface to use instead of Observable in input arguments#1475

Closed
vladima wants to merge 1 commit intoReactiveX:masterfrom
vladima:subscribableInterface
Closed

fix(Observable): introduce Subscribable interface to use instead of Observable in input arguments#1475
vladima wants to merge 1 commit intoReactiveX:masterfrom
vladima:subscribableInterface

Conversation

@vladima
Copy link
Copy Markdown
Contributor

@vladima vladima commented Mar 15, 2016

public surface of Subscribable is much smaller than in Observable which significantly reduces space to explore in when doing type-related-to checks in TypeScript compiler.

@benlesh
Copy link
Copy Markdown
Member

benlesh commented Mar 16, 2016

This sounds like a better change. How do the builds perform with this change?

@benlesh
Copy link
Copy Markdown
Member

benlesh commented Mar 16, 2016

Also, for my own reference, this is semi-related to #1463 .. but only in the typings aspect.

@vladima
Copy link
Copy Markdown
Contributor Author

vladima commented Mar 16, 2016

Perf is roughly on par with tag properties

@vladima
Copy link
Copy Markdown
Contributor Author

vladima commented Mar 17, 2016

@Blesh can you please tell if there is anything else that needs to be done on this PR?

@benlesh
Copy link
Copy Markdown
Member

benlesh commented Mar 17, 2016

@vladima sorry, I've been sick and busy catching up from being sick...

@benlesh
Copy link
Copy Markdown
Member

benlesh commented Mar 17, 2016

This LGTM.

@vladima
Copy link
Copy Markdown
Contributor Author

vladima commented Mar 18, 2016

Great! Does it mean that it will be available in the next beta release of RxJS?

@kwonoj
Copy link
Copy Markdown
Member

kwonoj commented Mar 18, 2016

Does it mean that it will be available in the next beta release of RxJS?

: I believe so. I'll double check and check this in around today or tomorrow, can be in time before next release freeze hits.

@kwonoj
Copy link
Copy Markdown
Member

kwonoj commented Mar 18, 2016

Merged with 2256e7b, great appreciate for effort @vladima ! 🎉

@lock
Copy link
Copy Markdown

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants