Skip to content

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Mar 17, 2016

Description:

It is not clearly known, but github seems prevent to render svg content in repo as markdown content, serves as plain text directly. (http://stackoverflow.com/a/21521184 / isaacs/github#316)
This PR updates image reference to use rawgit (https://rawgit.com/) serves correct content type.

Maybe just replace image to non-svg would be better solution? /cc @staltz

@staltz
Copy link
Member

staltz commented Mar 17, 2016

Oh, wait a minute. That SVG is primarily used for the ESDoc website, and works normally there. While it is possible to open the docs/ directory in GitHub and just read it from here, the recommended docs should be reactivex.io/rxjs. This is normal also in Cycle.js docs https://github.com/cyclejs/cyclejs.github.io/blob/master/_posts/2015-01-30-dialogue.md and also in React docs https://github.com/facebook/react/blob/master/docs/docs/thinking-in-react.md

@staltz
Copy link
Member

staltz commented Mar 17, 2016

And it's important that the image is SVG, for good and scalable resolution, but specially because the SVG file is text/code which can be edited. I.e. no one needs some "original" Illustrator file if they want to edit the image. It's open source.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 17, 2016

This PR's not supposed to check in immediately, wanted to confirm its behavior. So it's ok to leave as-is? I thought it's expected to display some sort of images, (may other ppl could think same if they visit github only)

@staltz
Copy link
Member

staltz commented Mar 17, 2016

Let's make sure they see a link to http://reactivex.io/rxjs

@kwonoj
Copy link
Member Author

kwonoj commented Mar 17, 2016

OK, let me close this PR without merging, thanks for clarification and sorry for inconvenience. Totally my misunderstanding.

@kwonoj kwonoj closed this Mar 17, 2016
@kwonoj kwonoj deleted the doc-operators branch March 17, 2016 08:06
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants